Repository navigation
fix(firmware): isolate fresh MR60 radar delivery from raw CSI - #2528
proffesor-for-testing wants to merge 5 commits into
Conversation
|
Independent parent review at Two fail-closed findings were fixed before the final flash: rejected nonzero split configuration previously could fall back to bulk; an unreadable NVS namespace previously could be treated as absent. Production sender/loader probes now cover both, preserving legacy behavior only for absent configuration or explicit zero. I independently executed Actual hardware/app outcome: final custom image SHA256 This is transport and diagnostic evidence, not validated human detection or numeric vital accuracy. An earlier occupied-area window reported no positive presence; alignment/beam membership and empty contrast remain uncontrolled/unexecuted. No room/model selection or server privacy/selected-output policy was changed. No main merge/release occurred. |
|
CI repaired at The original QEMU/fuzz failures were Ubuntu APT DNS errors before test execution. The workflow now uses the digest-pinned official ESP-IDF v5.4 image's QEMU package/runtime and the Ubuntu24.04 runner's preinstalled Clang18. This removes both failing APT setup steps and the floating QEMU source build. The QEMU matrix, consumer commands, NVS assertions, fuzz budgets, sanitizers, crash checks and swarm assertions are preserved. The three production radar regression probes also execute in the fuzz job. Executed: offline pinned-container setup, ESP32-S3 machine and artifact relocation; YAML/structural comparison; hosted Linux fuzz and regression jobs; all QEMU cases and both swarm runs; firmware builds. Local Mac fuzzing was not counted as passing because its sanitizer runtime hung before main; the owned process was stopped and diagnostic evidence preserved. This commit changes only |
There was a problem hiding this comment.
NO BLOCK in the bounded MR60 freshness/split-delivery code at 5302592. This is a Codex source/test COMMENT, not independent human approval or physical sensing qualification.
EXECUTED today: make run_mmwave_freshness run_radar_fused_route run_radar_nvs passes against production parser/sender/NVS code. Probes cover UART silence, independent field expiry, malformed/range-invalid frames, absence/recovery and clock boundaries; exact fused packet identity, source/port/rate bounds, no raw fallback on split-route failure; and default/explicit/invalid/wrong-type NVS intent.
STATIC: field timestamps advance only on accepted data; absence clears prior rate/distance authority. Split routing requires an explicit distinct nonprivileged port and a validated48-byte MR60 packet; raw CSI keeps its configured destination. No valid-looking fallback is fabricated on failure. Default route behavior remains compatible.
Current hosted checks:19 pass, two expected release-only skips. Parent#2513 remains a separate CI/review dependency; no merge is performed by this review. Mobile#252 explanations/quality arithmetic are being repaired separately and do not change firmware or sensing thresholds.
Limits: prior controller flash/readback and live delivery establish transport only. The earlier occupied0/43 window remains counterevidence; later positive traffic does not replace controlled occupied/empty comparison. No flash, Wi-Fi/NVS change, app/helper replacement, room capture or clinical/accuracy validation performed today. Exact next gate: parent/human review and controlled physical conditions before a sensing-validation claim.
November12 follow-up: the operator confirmed power-only radar data delivery in BOTH Mac and phone apps. Passive mDNS independently shows the C6/controller on Wi-Fi and the configured receiver address matches this Mac. This supersedes today's earlier transport-silent observation. No agent-side reset/flash/configuration write; exact binary was not re-read today. It does not close the controlled occupied/empty sensing check.
The MR60BHA2 carrier reused one UDP destination for raw CSI and fused radar, and its cached UART fields could remain current indefinitely. This change makes the custom controller usable as a separate radar source without inserting its raw CSI into an existing RF learner.
csi_cfgU16radar_portopt-in, inheritingtarget_ip. Absent/zero preserves legacy single-destination behavior. Invalid nonzero, wrong-type/unreadable keys and namespace-read failures block radar routing instead of silently falling back. No new HTTP/serial configuration authority is introduced.0xC5110004, configured node ID/MR60 type, finite bounds and presence/count consistency; cap it at two datagrams/second. Invalid packets and send failures never fall back to bulk. Raw CSI, ordinary edge, sync and feature traffic retain the original destination. Server selection/privacy gates remain unchanged.Stacked dependency: targets
integration/ruv-main-reconcile-20261110(#2513), containing the dedicated carrier profile from #2514. Main merge/release are outside this PR; it remains draft pending dependency and hosted review/CI.Validation:
b8a397360d36399e9fbf10bee96881f390156a1c023ea65b91a7b883f6ace6ba.Limits: the five-second UART expiry is an engineering fail-closed bound, not a manufacturer cadence guarantee or sensing qualification. A prior occupied-area-only control did not establish positive detection; empty/in-beam contrast, UART-disconnection recovery and clinical reference checks remain unexecuted. Transport/current source visibility is verified; detection and vital accuracy are not claimed. Private network settings, NVS images, device backups and biometric values are excluded from this PR.
CI bootstrap follow-up at
3cd433213fb2f14f33d0faee87645e6be53588c2:This follow-up changes CI only; installed firmware/controller/app configuration is unchanged.
Parent CI synchronization at
5302592e6695bc1ae0a164c9ea6f19a8ef5a7a4c: merged parent repair dc6149f into this development branch, retaining the child radar regression step. The CI workflow conflict is resolved.firmware/is byte-identical to the previously tested/flashed production tree; no reflash/app/helper change occurred. Fresh child CI on5302592e is now fully green; the earlier30-pass receipt remains a historical result at3cd43321. Draft status and the parent dependency remain.